func.sh: do not hang when grow-continue can't finish #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mku514k
reviewed
Oct 25, 2024
ktanska
force-pushed
the
fix_wait
branch
2 times, most recently
from
72bb550 to
9672991
Compare
|
@ktanska I see you marked the conversation as resolved, but I do not see any changes pushed here for the first patch. Do you plan to update first commit? |
ktanska
force-pushed
the
fix_wait
branch
3 times, most recently
from
7072c41 to
0fe25c2
Compare
This test could hang if "check" action is not written to sync_action. If this value didn't appear, test hanged on infinite while loop. Add 5 second timeout to loop. Signed-off-by: Kinga Stefaniuk <[email protected]>
ktanska
force-pushed
the
fix_wait
branch
2 times, most recently
from
b409702 to
72265bd
Compare
Contributor
Author
|
@mtkaczyk @mku514k please review |
mtkaczyk
approved these changes
Nov 12, 2024
When grow-continue process is ongoing, sync_action indicates that recovery is in progress. If grow-continue does not finish, even if sync_action is not "reshape" anymore, the test should fail. Signed-off-by: Kinga Stefaniuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When grow-continue process is on, the sync_action represents value which means that recovery is in progress. When grow-continue does not finish, even if sync_action is not reshape anymore, test should fail.